Rework MockInternalClusterInfoService #90092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes MockInternalClusterInfoService to fake entire data structure rather than a getter call. This is required if the structure is copied by some code (such as desired balance allocator).
idegtiarenko
added
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
commented
Sep 15, 2022
| @Override | ||
| public String toString() { | ||
| return Strings.toString(this, true, false); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This allows to produce readable message if entire object is used in assertion
DaveCTurner
approved these changes
Sep 15, 2022
| ); | ||
| @Override | ||
| ShardStats[] adjustShardStats(ShardStats[] shardsStats) { | ||
| var shardSizeFunctionCopy = this.shardSizeFunction; |
Contributor
There was a problem hiding this comment.
I think at one point we did need this to be lazier, but not any more it seems. In fact today all implementations are just constant functions returning either 0 or 1 so there's not really a need for this to be a function at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes MockInternalClusterInfoService to fake entire data structure rather
than a getter call. This is required if the structure is copied by some
code (such as desired balance allocator).